Bug 12267: Remove borrower_attributes.password
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 11 Apr 2016 09:05:01 +0000 (10:05 +0100)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Fri, 22 Apr 2016 23:08:32 +0000 (23:08 +0000)
commit38094a260e42c7937460946518a2978d2385ba14
treed021d87dc6cb6c0b736306abed5b8be6cbd282a4
parent366e31f8c020080b9a0319abb7d2c02e10f42a40
Bug 12267: Remove borrower_attributes.password

When creating a patron attribute type, there is a "Allow password"
checkbox. If checked, the librarian will be able to enter a password for
this patron attribute when editing a patron.
The goal was to allow a patron to log in with a secondary password.
However, this feature has never been implemented.

"""
commit 6fc62bcd321eddb0fd3ae46903e9ab6c8b1db2cd
  CommitDate: Mon May 12 09:03:00 2008 -0500
  extended patron attributes tables & syspref (DB rev 081)

- password_allowed (if set, staff patron editor will
  allow a password to be associated with a value; this
  is mostly a hook for functionality to be implemented
  in the future.
"""

To decrease maintainability, this patch suggest to remove the 2 DB fields
borrower_attributes.password and
borrower_attribute_types.password_allowed
If they have not used by the library.

Test plan:
- Edit a patron attribute type and select "allow password"
- Edit a patron and defined a password for this attribute
- Execute the DB entry
- Note that you get a warning
- Empty the password field
- Execute the DB entry
- You do not get the warning and the 2 DB fields have been removed

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
C4/Members/AttributeTypes.pm
C4/Members/Attributes.pm
admin/patron-attr-types.pl
installer/data/mysql/atomicupdate/bug_12267.perl [new file with mode: 0644]
installer/data/mysql/kohastructure.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
members/memberentry.pl
t/Members_AttributeTypes.t
t/Members_Attributes.t