Bug 20415: Remove UseKohaPlugins system preference
authorFridolin Somers <fridolin.somers@biblibre.com>
Thu, 19 Mar 2020 14:22:30 +0000 (17:22 +0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 26 Mar 2020 11:42:02 +0000 (11:42 +0000)
commit21c9b685bfdb255a872ce27d4e0570673d0de8e7
tree9ec68f94bd774579d6237f8e83207d7a52893ad1
parentf6c322e3253a8c9893144d19da111e5b5c8a55cf
Bug 20415: Remove UseKohaPlugins system preference

Owen Leonard 2018-03-16 10:47:47 UTC :
<<
I don't think the system preference adds any security. There are already multiple permissions required for working with plugins:

- Configure plugins
- Manage plugins ( install / uninstall )
- Use report plugins
- Use tool plugins

And even with those permissions your server must be configured to allow the use of plugins.
>>

Test plan :
1) Install kitchen sink plugin https://github.com/bywatersolutions/koha-plugin-kitchen-sink
2) Run misc/devel/install_plugins.pl
3) Set config enable_plugins=1
4) Check all parts of the plugin are working
5) Set config enable_plugins=0
6) Check all parts of the plugin are disabled

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
28 files changed:
C4/Auth.pm
C4/Biblio.pm
C4/UsageStats.pm
Koha/Item.pm
Koha/Patron.pm
Koha/REST/Plugin/PluginRoutes.pm
Koha/REST/V1/Static.pm
Koha/Template/Plugin/KohaPlugins.pm
admin/admin-home.pl
admin/edi_accounts.pl
catalogue/detail.pl
installer/data/mysql/atomicupdate/bug_20415.sql [new file with mode: 0644]
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
misc/devel/install_plugins.pl
opac/opac-account.pl
plugins/plugins-enable.pl
plugins/plugins-home.pl
plugins/plugins-uninstall.pl
plugins/plugins-upload.pl
plugins/run.pl
t/db_dependent/ImportBatch.t
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
t/db_dependent/Koha/Plugins/Patron.t
t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
t/db_dependent/Koha/Template/Plugin/KohaPlugins.t
t/db_dependent/UsageStats.t
tools/stage-marc-import.pl