Bug 19458: Self-check module highlighting
authorAgustin Moyano <agustinmoyano@theke.io>
Thu, 13 Dec 2018 04:51:38 +0000 (01:51 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 11 Jan 2019 12:32:10 +0000 (12:32 +0000)
In SCO Module there is no difference on how new checkouts and renewals are shown from previous ones. This commit is done to address that issue.

How to test:
1. Go to /cgi-bin/koha/sco/sco-main.pl and login.
2. Checkout a new item.
3. In checkout's table new checkouts should be easily identifiable.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
opac/sco/sco-main.pl

index df09322..bfa3aec 100644 (file)
                                         </div>
                                         <input type="hidden" name="op" value="checkout" />
                                         <input type="hidden" name="patronid" value="[% patronid | html %]" />
+                                        <input type="hidden" name="newissues" value="[% newissues | html %]" />
                                     </fieldset>
                                 </form>
 
                                             <tr>
                                                 <td>[% ISSUE.issuedate | html %]</td>
                                                 <td>
+                                                    [% IF ( newissues.match(ISSUE.barcode)) %]
+                                                        <span class="label label-info">NEW</span>
+                                                    [% END %]
                                                     [% UNLESS ( noitemlinks ) %]
                                                         <a href="/cgi-bin/koha/opac-detail.pl?bib=[% ISSUE.  biblionumber | uri %]">[% ISSUE.title | html %]</a>
                                                     [% ELSE %]
index 9fcf729..49018da 100755 (executable)
@@ -93,15 +93,16 @@ if (defined C4::Context->preference('AllowSelfCheckReturns')) {
 }
 
 my $issuerid = $loggedinuser;
-my ($op, $patronid, $patronlogin, $patronpw, $barcode, $confirmed) = (
+my ($op, $patronid, $patronlogin, $patronpw, $barcode, $confirmed, $newissues) = (
     $query->param("op")         || '',
     $query->param("patronid")   || '',
     $query->param("patronlogin")|| '',
     $query->param("patronpw")   || '',
     $query->param("barcode")    || '',
     $query->param("confirmed")  || '',
+    $query->param("newissues")  || '',
 );
-
+my @newissueslist = split /,/, $newissues;
 my $issuenoconfirm = 1; #don't need to confirm on issue.
 my $issuer   = Koha::Patrons->find( $issuerid )->unblessed;
 my $item     = GetItem(undef,$barcode);
@@ -215,7 +216,9 @@ elsif ( $patron and $op eq "checkout" ) {
                 )->count;
             }
             AddIssue( $borrower, $barcode );
-
+            push @newissueslist, $barcode;
+            print 'Issues \n';
+            print join(',', @newissueslist);
             if ( $hold_existed ) {
                 my $dtf = Koha::Database->new->schema->storage->datetime_parser;
                 $template->param(
@@ -245,6 +248,7 @@ elsif ( $patron and $op eq "checkout" ) {
 } # $op
 
 if ($borrower) {
+    print 'borrower \n';
 #   warn "issuer's  branchcode: " .   $issuer->{branchcode};
 #   warn   "user's  branchcode: " . $borrower->{branchcode};
     my $borrowername = sprintf "%s %s", ($borrower->{firstname} || ''), ($borrower->{surname} || '');
@@ -267,6 +271,7 @@ if ($borrower) {
         borrowername => $borrowername,
         issues_count => scalar(@checkouts),
         ISSUES => \@checkouts,
+        newissues => join(',',@newissueslist),
         patronid => $patronid,
         patronlogin => $patronlogin,
         patronpw => $patronpw,