Bug 6351: Unable to delete branch-specific circulation rule
authorD Ruth Bavousett <ruth@bywatersolutions.com>
Tue, 17 May 2011 15:45:48 +0000 (11:45 -0400)
committerChris Cormack <chrisc@catalyst.net.nz>
Fri, 27 May 2011 09:02:44 +0000 (21:02 +1200)
The URL on the page did not have a branchcode, so the delete failed silently, and
returned the user to the "All" rules page.  Turns out, the array for the rules was
not being populated with the branchcode!

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

admin/smart-rules.pl

index 3c77f93..5ba92d8 100755 (executable)
@@ -376,6 +376,7 @@ my $sth2 = $dbh->prepare("
 $sth2->execute($branch);
 
 while (my $row = $sth2->fetchrow_hashref) {
+    $row->{'current_branch'} ||= $row->{'branchcode'};
     $row->{'humanitemtype'} ||= $row->{'itemtype'};
     $row->{'default_humanitemtype'} = 1 if $row->{'humanitemtype'} eq '*';
     $row->{'humancategorycode'} ||= $row->{'categorycode'};