Bug 18928: (follow-up) Unset max_holds rule if needed
authorJosef Moravec <josef.moravec@gmail.com>
Wed, 24 Apr 2019 21:11:29 +0000 (21:11 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 1 Jul 2019 13:57:47 +0000 (14:57 +0100)
Test plan:
1) Set all values in Default checkout, hold and return policy section on
circulation rules admin page, try for all libraries and for one specific
library. Save.
2) Click on unset and confitm
--> without patch, the Maximum total holds allowed value remains
--> with patch the unset removex Maximum holds value too

Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

admin/smart-rules.pl

index 41c61f7..2bdebc9 100755 (executable)
@@ -104,6 +104,7 @@ elsif ($op eq 'delete-branch-cat') {
                          holdallowed             => undef,
                          hold_fulfillment_policy => undef,
                          returnbranch            => undef,
+                         max_holds               => undef,
                      }
                  }
              );
@@ -133,6 +134,7 @@ elsif ($op eq 'delete-branch-cat') {
                     holdallowed             => undef,
                     hold_fulfillment_policy => undef,
                     returnbranch            => undef,
+                    max_holds               => undef,
                 }
             }
         );