Bug 20581: (follow-up) Fix statusalias return
authorAndrew Isherwood <andrew.isherwood@ptfs-europe.com>
Fri, 12 Oct 2018 13:31:45 +0000 (14:31 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 22 Feb 2019 14:31:31 +0000 (14:31 +0000)
As per
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c57

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Koha/Illrequest.pm

index 18cd57e..d30aba8 100644 (file)
@@ -112,15 +112,19 @@ available for request.
 
 =head3 statusalias
 
+    my $statusalias = $request->statusalias;
+
+Return a request's status alias, if one is defined, otherwise
+return implicit undef
+
 =cut
 
 sub statusalias {
     my ( $self ) = @_;
-    return $self->status_alias ?
-        Koha::AuthorisedValue->_new_from_dbic(
-            scalar $self->_result->status_alias
-        ) :
-        undef;
+    return unless $self->status_alias;
+    return Koha::AuthorisedValue->_new_from_dbic(
+        scalar $self->_result->status_alias
+    );
 }
 
 =head3 illrequestattributes