Bug 20348: SIP2 patron identification fails to use userid

Replaces "or" with "||" in variable assignment

second attempt to retrieve borrower was not being executed due
to changed precedence

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm
index 1a90b77..6390fc0 100644 (file)
--- a/C4/SIP/ILS/Patron.pm
+++ b/C4/SIP/ILS/Patron.pm
@@ -33,7 +33,7 @@ sub new {
     my $type = ref($class) || $class;
     my $self;
     $kp = Koha::Patrons->find( { cardnumber => $patron_id } )
-      or Koha::Patrons->find( { userid => $patron_id } );
+      || Koha::Patrons->find( { userid => $patron_id } );
     $debug and warn "new Patron: " . Dumper($kp->unblessed) if $kp;
     unless ($kp) {
         syslog("LOG_DEBUG", "new ILS::Patron(%s): no such patron", $patron_id);