Bug 13140: Add a notice on the About page about GRS-1 deprecated

This patch changes the text for zebra_auth_index_mode and zebra_bib_index_mode
entries missing on koha-conf.xml telling the user GRS-1 is deprecated.

It also adds another check for those preferences set to GRS-1, and shows a
warning message if set to grs1.

To test:
- Apply the patch and try all combinations:
- zebra_auth_index_mode and zebra_bib_index_mode missing
- zebra_auth_index_mode and zebra_bib_index_mode set to grs1
- Sign off :-D

Regards

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

I've played with the 3 related koha-conf.xml file parameters:
zebra_auth_index_moda, zebra_bib_index_mode missing, and use_zebra_facets.
Inconsitencies are properly reported in About page thanks to this patch. It
would be helpfull to admin upgrading their Koha installation.

And by the way, thanks Tomas for the new Zebra facets functionnality. It's a
'joy' to see it into Koha.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

Works as described, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/about.pl b/about.pl
index 339f4e2..4fbc7e8 100755 (executable)
--- a/about.pl
+++ b/about.pl
@@ -84,12 +84,18 @@ if ( ! defined C4::Context->config('zebra_bib_index_mode') ) {
     push @xml_config_warnings, {
         error => 'zebra_bib_index_mode_warn'
     };
+} else {
+    push @xml_config_warnings, { error => 'zebra_bib_grs_warn' }
+        if C4::Context->config('zebra_bib_index_mode') eq 'grs1';
 }
 
 if ( ! defined C4::Context->config('zebra_auth_index_mode') ) {
     push @xml_config_warnings, {
         error => 'zebra_auth_index_mode_warn'
     };
+} else {
+    push @xml_config_warnings, { error => 'zebra_auth_grs_warn' }
+        if C4::Context->config('zebra_auth_index_mode') eq 'grs1';
 }
 
 # Test QueryParser configuration sanity

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
index 75a367d..6e87b37 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
@@ -145,9 +145,39 @@
                 <caption>XML configuration file</caption>
             [% FOREACH config_entry IN xml_config_warnings %]
                 [% IF config_entry.error == 'zebra_bib_index_mode_warn' %]
-                <tr><th scope="row"><b>Warning</b> </th><td>The &lt;zebra_bib_index_mode&gt; entry is missing in your configuration file. It should be set to <strong>dom</strong> or <strong>grs1</strong>. It will default to <strong>grs1</strong> but this could change in the future.</td></tr>
+                <tr>
+                    <th scope="row"><b>Warning</b></th>
+                    <td>The &lt;zebra_bib_index_mode&gt; entry is missing in your configuration file.
+                        It should be set to <strong>dom</strong> or <strong>grs1</strong> (deprecated).
+                        It will default to <strong>dom</strong>.
+                    </td>
+                </tr>
                 [% ELSIF config_entry.error == 'zebra_auth_index_mode_warn' %]
-                <tr><th scope="row"><b>Warning</b> </th><td>The &lt;zebra_auth_index_mode&gt; entry is missing in your configuration file. It should be set to <strong>dom</strong> or <strong>grs1</strong>. It will default to <strong>dom</strong> but this could change in the future.</td></tr>
+                <tr>
+                    <th scope="row"><b>Warning</b></th>
+                    <td>The &lt;zebra_auth_index_mode&gt; entry is missing in your configuration file.
+                        It should be set to <strong>dom</strong> or <strong>grs1</strong> (deprecated).
+                        It will default to <strong>dom</strong>.
+                    </td>
+                </tr>
+                [% ELSIF config_entry.error == 'zebra_bib_grs_warn' %]
+                <tr>
+                    <th scope="row"><b>Warning</b></th>
+                    <td>The &lt;zebra_bib_index_mode&gt; entry is set to <strong>grs1</strong>.
+                        GRS-1 support is now deprecated and will be removed in future releases.
+                        Please use DOM instead by setting &lt;zebra_bib_index_mode&gt; to
+                        <strong>dom</strong> (full reindex required).
+                    </td>
+                </tr>
+                [% ELSIF config_entry.error == 'zebra_auth_grs_warn' %]
+                <tr>
+                    <th scope="row"><b>Warning</b></th>
+                    <td>The &lt;zebra_auth_index_mode&gt; entry is set to <strong>grs1</strong>.
+                        GRS-1 support is now deprecated and will be removed in future releases.
+                        Please use DOM instead by setting &lt;zebra_auth_index_mode&gt; to
+                        <strong>dom</strong> (full reindex required).
+                    </td>
+                </tr>
                 [% ELSIF config_entry.error == 'queryparser_entry_missing' %]
                 <tr>
                     <th scope="row"><b>Warning</b></th>