Bug 21975: (follow-up) get item datas from previous SQL query
authorFridolin Somers <fridolin.somers@biblibre.com>
Fri, 12 Apr 2019 09:42:39 +0000 (11:42 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 16 Apr 2019 13:17:33 +0000 (13:17 +0000)
Forced by removal of C4::Items::GetItem from Bug 21206

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

C4/Items.pm

index dcbf4ae..f0f70c7 100644 (file)
@@ -2610,7 +2610,7 @@ sub ToggleNewStatus {
         my @params;
 
         my $query = q|
-            SELECT items.biblionumber, items.itemnumber
+            SELECT items.*
             FROM items
             LEFT JOIN biblioitems ON biblioitems.biblionumber = items.biblionumber
             WHERE 1
@@ -2643,7 +2643,7 @@ sub ToggleNewStatus {
             my $itemnumber = $values->{itemnumber};
             for my $substitution ( @$substitutions ) {
                 next unless $substitution->{field};
-                next if ( $item->{ $substitution->{item_field} } eq $substitution->{value} );
+                next if ( $values->{ $substitution->{item_field} } eq $substitution->{value} );
                 C4::Items::ModItem( { $substitution->{item_field} => $substitution->{value} }, $biblionumber, $itemnumber )
                     unless $report_only;
                 push @{ $report->{$itemnumber} }, $substitution;