projects / koha-equinox.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch (parent: fe0a247)
Bug 21335: Remove redundant includes of right-to-left.css
authorKatrin Fischer <katrin.fischer.83@web.de>
Wed, 6 Feb 2019 04:31:28 +0000 (04:31 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 22 Feb 2019 13:34:05 +0000 (13:34 +0000)
Fixes redundant includes of the right-to-left.css file.
There is no need to include it in the .tt files as it's part
of the doc-head-close.inc.

Note:
  Make sure your *BaseURL preferences are correctly set as
  this will make the switching between languages work
  correctly and throw you back to the start page otherwise
  every time you switch

Test:
- Install an RTL language like Arabic (ar-Arab)
- Test various pages with English and RTL language:
  - Authorities home page
  - Adding a new bibliographic record
  - Adding a new item or editing items
  - Advanced cataloguing (Rancor) editor
  - Labels start page
  - OPAC detail page
- Verify display is correct and right-to-left.css is available

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt patch | blob | history
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt patch | blob | history
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt patch | blob | history
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt patch | blob | history
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt patch | blob | history

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
index b0856b9..2a626c0 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
@@ -168,9 +168,6 @@ function confirmnotdup(redirect){
   });
 </script>
 
-[% IF ( bidi ) %]
-   [% Asset.css("css/right-to-left.css") | $raw %]
-[% END %]
 </head>
 <body id="auth_authorities" class="auth">
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
index 41326ab..de2429b 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
@@ -405,9 +405,6 @@ function Changefwk() {
   });
 </script>
 
-[% IF ( bidi ) %]
-   [% Asset.css("css/right-to-left.css") | $raw %]
-[% END %]
 </head>
 <body id="cat_addbiblio" class="cat">
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
index 671668b..2820c4c 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
@@ -139,9 +139,6 @@ function confirm_deletion() {
   });
 </script>
 
-[% IF ( bidi ) %]
-   [% Asset.css("css/right-to-left.css") | $raw %]
-[% END %]
 </head>
 <body id="cat_additem" class="cat">
 [% INCLUDE 'header.inc' %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
index ff16b20..5181cdf 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
@@ -8,9 +8,6 @@
 [% Asset.css("css/humanmsg.css") | $raw %]
 [% Asset.js("js/cataloging.js") | $raw %]
 [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %]
-[% IF ( bidi ) %]
-   [% Asset.css("css/right-to-left.css") | $raw %]
-[% END %]
 </head>
 <body id="cat_addbiblio" class="cat">
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt
index eb5b9f3..f4898fc 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-home.tt
@@ -4,9 +4,6 @@
     [% INCLUDE 'doc-head-open.inc' %]
     <title>Koha &rsaquo; Tools &rsaquo; Label creator</title>
     [% INCLUDE 'doc-head-close.inc' %]
-    [% IF ( bidi ) %]
-    [% Asset.css("css/right-to-left.css") | $raw %]
-    [% END %]
 </head>
 <body id="labels_label-home" class="tools labels">
     [% INCLUDE 'header.inc' %]
Koha with Equinox developments in process and local tweaks