Bug 13795: Remove occurences of unused columns in code

These patch removes these two columns from backfill_statstics script
and from columns.def - this file is used to create description in guided
reports

Test plan:
1. Run installer/data/mysql/backfull_statistics.pl
--> without this patch, there are associatedborrower and usercode errors
reported
--> with patch, these two columns are not reported

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/installer/data/mysql/backfill_statistics.pl b/installer/data/mysql/backfill_statistics.pl
index 8308b6b..daa8e83 100755 (executable)
--- a/installer/data/mysql/backfill_statistics.pl
+++ b/installer/data/mysql/backfill_statistics.pl
@@ -24,9 +24,7 @@ sub get_counts() {
        (SELECT count(*) FROM statistics WHERE branch="NO_LIBRARY"       ) AS NO_LIBRARY,
        (SELECT count(*) FROM statistics WHERE branch             IS NULL) AS NULL_BRANCH,
        (SELECT count(*) FROM statistics WHERE itemtype           IS NULL AND itemnumber IS NOT NULL) AS NULL_ITEMTYPE,
-       (SELECT count(*) FROM statistics WHERE usercode           IS NULL) AS NULL_USERCODE,
        (SELECT count(*) FROM statistics WHERE borrowernumber     IS NULL) AS NULL_BORROWERNUMBER,
-       (SELECT count(*) FROM statistics WHERE associatedborrower IS NULL) AS NULL_ASSOCIATEDBORROWER,
        (SELECT count(*) FROM statistics                                 ) AS Total
        );
        my $sth = $dbh->prepare($query);

diff --git a/koha-tmpl/intranet-tmpl/prog/en/columns.def b/koha-tmpl/intranet-tmpl/prog/en/columns.def
index 7073360..05112eb 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/columns.def
+++ b/koha-tmpl/intranet-tmpl/prog/en/columns.def
@@ -111,7 +111,6 @@
 <field name="statistics.value">Value</field>
 <field name="statistics.type">Type</field>
 <field name="statistics.other"></field>
-<field name="statistics.usercode">User code</field>
 <field name="statistics.itemnumber">Item number</field>
 <field name="statistics.itemtype">Itemtype</field>
 <field name="statistics.borrowernumber">Borrower number</field>