Bug 19008: More database cleanups - deleted patrons

misc/cronjobs/cleanup_database.pl provides some database cleanup.
Yet some tables that could need cleanup are not in this script.

This patch adds cleanup for deletedborrowers table.

Test plan :
- Count : select count(*),date(updated_on) from deletedborrowers group by date(updated_on);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-patrons 30
- Recount

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl
index 32a4cdd..cfcc144 100755 (executable)
--- a/misc/cronjobs/cleanup_database.pl
+++ b/misc/cronjobs/cleanup_database.pl
@@ -45,7 +45,7 @@ use Koha::UploadedFiles;
 
 sub usage {
     print STDERR <<USAGE;
-Usage: $0 [-h|--help] [--sessions] [--sessdays DAYS] [-v|--verbose] [--zebraqueue DAYS] [-m|--mail] [--merged] [--import DAYS] [--logs DAYS] [--searchhistory DAYS] [--restrictions DAYS] [--all-restrictions] [--fees DAYS] [--temp-uploads] [--temp-uploads-days DAYS] [--uploads-missing 0|1 ] [--statistics DAYS] [--deleted-catalog DAYS]
+Usage: $0 [-h|--help] [--sessions] [--sessdays DAYS] [-v|--verbose] [--zebraqueue DAYS] [-m|--mail] [--merged] [--import DAYS] [--logs DAYS] [--searchhistory DAYS] [--restrictions DAYS] [--all-restrictions] [--fees DAYS] [--temp-uploads] [--temp-uploads-days DAYS] [--uploads-missing 0|1 ] [--statistics DAYS] [--deleted-catalog DAYS] [--deleted-patrons DAYS]
 
    -h --help          prints this help message, and exits, ignoring all
                       other options
@@ -86,6 +86,7 @@ Usage: $0 [-h|--help] [--sessions] [--sessdays DAYS] [-v|--verbose] [--zebraqueu
    --statistics DAYS       Purge entries from statistics older than DAYS days.
    --deleted-catalog  DAYS Purge deleted catalog older than DAYS
                            in tables deleteditems, deletedbiblioitems, deletedbiblio_metadata and deletedbiblio
+   --deleted-patrons DAYS  Purge deleted patrons older than DAYS days.
 USAGE
     exit $_[0];
 }
@@ -114,6 +115,7 @@ my $uploads_missing;
 my $oauth_tokens;
 my $pStatistics;
 my $pDeletedCatalog;
+my $pDeletedPatrons;
 
 GetOptions(
     'h|help'            => \$help,
@@ -140,6 +142,7 @@ GetOptions(
     'oauth-tokens'      => \$oauth_tokens,
     'statistics:i'      => \$pStatistics,
     'deleted-catalog:i' => \$pDeletedCatalog,
+    'deleted-patrons:i' => \$pDeletedPatrons,
 ) || usage(1);
 
 # Use default values
@@ -176,6 +179,7 @@ unless ( $sessions
     || $oauth_tokens
     || $pStatistics
     || $pDeletedCatalog
+    || $pDeletedPatrons
 ) {
     print "You did not specify any cleanup work for the script to do.\n\n";
     usage(1);
@@ -401,6 +405,18 @@ if ($pDeletedCatalog) {
     print "Done with purging deleted catalog.\n" if $verbose;
 }
 
+if ($pDeletedPatrons) {
+    print "Purging deleted patrons older than $pDeletedPatrons days.\n" if $verbose;
+    $sth = $dbh->prepare(
+        q{
+            DELETE FROM deletedborrowers
+            WHERE updated_on < DATE_SUB(CURDATE(), INTERVAL ? DAY)
+        }
+    );
+    $sth->execute($pDeletedPatrons);
+    print "Done with purging deleted patrons.\n" if $verbose;
+}
+
 exit(0);
 
 sub RemoveOldSessions {