Bug 14457: (QA follow-up) Fix QA script complaints and amend system preference text

Pod coverage for 'NAME'.
Moved sysprefs in order and moved semicolon to last line.
Replaced tab indentation with spaces.
Added "Swedish service for spellchecking" to the syspref description.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm b/Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm
index 6177892..e0a8b1b 100644 (file)
--- a/Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm
+++ b/Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm
@@ -71,10 +71,18 @@ This module provides facilities for using the LIBRIS spell checker API
 
 =over
 
+=item NAME
+
+my $name = $plugin->NAME;
+
+=back
+
 =item get_suggestions(query)
 
 Sends in the search query and gets an XML with a suggestion
 
+my $suggestions = $plugin->get_suggestions(\%query);
+
 =back
 
 =cut

diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
index 40488d1..a490bd6 100644 (file)
--- a/installer/data/mysql/sysprefs.sql
+++ b/installer/data/mysql/sysprefs.sql
@@ -269,6 +269,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('LibraryThingForLibrariesEnabled','0','','Enable or Disable Library Thing for Libraries Features','YesNo'),
 ('LibraryThingForLibrariesID','','','See:http://librarything.com/forlibraries/','free'),
 ('LibraryThingForLibrariesTabbedView','0','','Put LibraryThingForLibraries Content in Tabs.','YesNo'),
+('LibrisKey', '', 'This key must be obtained at http://api.libris.kb.se/. It is unique for the IP of the server.', NULL, 'Free'),
+('LibrisURL', 'http://api.libris.kb.se/bibspell/', 'This it the base URL for the Libris spellchecking API.',NULL,'Free'),
 ('LinkerKeepStale','0',NULL,'If ON the authority linker will keep existing authority links for headings where it is unable to find a match.','YesNo'),
 ('LinkerModule','Default','Default|FirstMatch|LastMatch','Chooses which linker module to use (see documentation).','Choice'),
 ('LinkerOptions','','','A pipe-separated list of options for the linker.','free'),
@@ -647,6 +649,5 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('XSLTListsDisplay','default','','Enable XSLT stylesheet control over lists pages display on intranet','Free'),
 ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'),
 ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
-('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'),
-('LibrisKey', '', 'This key must be obtained at http://api.libris.kb.se/. It is unique for the IP of the server.', NULL, 'Free'),
-('LibrisURL', 'http://api.libris.kb.se/bibspell/', 'This it the base URL for the Libris spellchecking API.',NULL,'Free');
+('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo')
+;

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt
index 32855eb..5bd7448 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt
@@ -16,8 +16,8 @@
             Suggest that patrons expand their searches to include
             broader/narrower/related terms.
         [% CASE 'LibrisSpellcheck' %]
-           Use the LIBRIS spellcheck API.
-       [% END %]
+            Use the LIBRIS spellcheck API.
+        [% END %]
         </div>
     </div>
 [% END %]

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
index fd53954..f1b87d8 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
@@ -245,6 +245,7 @@ Searching:
             - on all variations of the ISBN. Note that this preference has no effect if UseQueryParser is on.
     Did you Mean/Spell checking:
         -
+            - "Swedish service for spellchecking.<br/>"
             - LIBRIS Spellchecking API key
             - pref: LibrisKey
             - "Can be obtained at http://api.libris.kb.se/bibspell."