Bug 19116: (followup) Add tests to highlight the problem in CheckReserves

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
index 90859ad..28521e8 100755 (executable)
--- a/t/db_dependent/Circulation.t
+++ b/t/db_dependent/Circulation.t
@@ -1730,7 +1730,7 @@ subtest 'AddReturn | is_overdue' => sub {
 };
 
 subtest 'Set waiting flag' => sub {
-    plan tests => 2;
+    plan tests => 4;
 
     my $library_1 = $builder->build( { source => 'Branch' } );
     my $patron_1  = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode} } } );
@@ -1768,12 +1768,17 @@ subtest 'Set waiting flag' => sub {
     my $hold = Koha::Holds->find( $reserve_id );
     is( $hold->found, 'T', 'Hold is in transit' );
 
+    my ( $status ) = CheckReserves($item->{itemnumber});
+    is( $status, 'Reserved', 'Hold is not waiting yet');
+
     set_userenv( $library_2 );
     $do_transfer = 0;
     AddReturn( $item->{barcode}, $library_2->{branchcode} );
     ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
     $hold = Koha::Holds->find( $reserve_id );
     is( $hold->found, 'W', 'Hold is waiting' );
+    ( $status ) = CheckReserves($item->{itemnumber});
+    is( $status, 'Waiting', 'Now the hold is waiting');
 };
 
 sub set_userenv {