Bug 20581: (follow-up) Fix status_alias -1 bug
authorAndrew Isherwood <andrew.isherwood@ptfs-europe.com>
Mon, 11 Feb 2019 11:08:52 +0000 (11:08 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 22 Feb 2019 14:31:31 +0000 (14:31 +0000)
Stupid bug, we need to pass NULL not -1 when unsetting status_alias

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Koha/Illrequest.pm

index 7d5eb48..98e4d70 100644 (file)
@@ -186,7 +186,7 @@ sub status_alias {
         # We need a way of accepting implied undef, so we can nullify
         # the status_alias column, when called from $self->status
         my $val = $newval eq "-1" ? undef : $newval;
-        my $newval = $self->SUPER::status_alias($newval);
+        my $newval = $self->SUPER::status_alias($val);
         if ($newval) {
             return $newval;
         } else {