Bug 23177: (QA follow-up) Move rollback to the end
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 21 Jun 2019 09:03:27 +0000 (09:03 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 21 Jun 2019 11:33:40 +0000 (12:33 +0100)
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

t/db_dependent/Circulation.t

index bc15512..173b7d6 100755 (executable)
@@ -3037,9 +3037,6 @@ subtest 'AddReturn should clear items.onloan for unissued items' => sub {
     is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
 };
 
-$schema->storage->txn_rollback;
-C4::Context->clear_syspref_cache();
-$cache->clear_from_cache('single_holidays');
 
 subtest 'AddRenewal and AddIssuingCharge tests' => sub {
 
@@ -3318,3 +3315,7 @@ subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
     is_deeply( $needsconfirmation, { RENTALCHARGE => '3' }, 'Item needs rentalcharge confirmation to be issued, increment' );
     $itemtype->rentalcharge_daily('0')->store;
 };
+
+$schema->storage->txn_rollback;
+C4::Context->clear_syspref_cache();
+$cache->clear_from_cache('single_holidays');