Bug 20144: (follow-up) Adjust /patrons endpoint
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 13 Feb 2018 18:52:45 +0000 (15:52 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 13 Feb 2018 19:08:47 +0000 (16:08 -0300)
Fields 'address' and 'city' have been maybe nullable by this bug. This
patch makes them nullable on the API as well.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail (randomly) when address or city are set to null by
         TestBuilder.
- Apply this patch
- Run:
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

api/v1/swagger/definitions/patron.json

index 735454f..2c6f9a6 100644 (file)
@@ -34,7 +34,7 @@
       "description": "street type of patron's primary address"
     },
     "address": {
-      "type": "string",
+      "type": ["string", "null"],
       "description": "first address line of patron's primary address"
     },
     "address2": {
@@ -42,7 +42,7 @@
       "description": "second address line of patron's primary address"
     },
     "city": {
-      "type": "string",
+      "type": ["string", "null"],
       "description": "city or town of patron's primary address"
     },
     "state": {