Bug 21337: (QA follow-up) Rename exception code
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 25 Oct 2018 12:25:10 +0000 (14:25 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 26 Oct 2018 16:06:57 +0000 (16:06 +0000)
Patron::Delete becomes Patron::FailedDelete.
Trivial replace.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Koha/Exceptions/Patron.pm
Koha/Patrons.pm
t/db_dependent/Koha/Patrons.t

index 754f004..8eac9c9 100644 (file)
@@ -6,7 +6,7 @@ use Exception::Class (
     'Koha::Exceptions::Patron' => {
         description => "Something went wrong!"
     },
-    'Koha::Exceptions::Patron::Delete' => {
+    'Koha::Exceptions::Patron::FailedDelete' => {
         description => "Deleting patron failed"
     },
 );
index 21061cd..dedf4c4 100644 (file)
@@ -229,7 +229,7 @@ sub delete {
         my ( $set, $params ) = @_;
         while( my $patron = $set->next ) {
             $patron->move_to_deleted if $params->{move};
-            $patron->delete == 1 || Koha::Exceptions::Patron::Delete->throw;
+            $patron->delete == 1 || Koha::Exceptions::Patron::FailedDelete->throw;
             $patrons_deleted++;
         }
     }, $self, $params );
index e2e8019..c552220 100644 (file)
@@ -443,7 +443,7 @@ subtest 'Koha::Patrons->delete' => sub {
     $patron1 = $builder->build_object({ class => 'Koha::Patrons' });
     $id1 = $patron1->borrowernumber;
     $set = Koha::Patrons->search({ borrowernumber => { '>=' => $id1 }});
-    throws_ok { $set->delete } 'Koha::Exceptions::Patron::Delete',
+    throws_ok { $set->delete } 'Koha::Exceptions::Patron::FailedDelete',
         'Exception raised for deleting patron';
 };