Bug 20945: Escape SQL parameters when constructing download links
authorNick Clemens <nick@bywatersolutions.com>
Thu, 14 Jun 2018 14:20:44 +0000 (14:20 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 29 Jun 2018 20:06:37 +0000 (20:06 +0000)
TO test:
1 - Create a report that takes a parameter
2 - Enter a parameter containing '%'
3 - Attempt to download report, note link is misconstructed
4 - Apply patch
5 - Reload
6 - Note URL is now correct

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc

index 99ce946..b773c9b 100644 (file)
@@ -49,7 +49,7 @@
 
         [% IF ( execute ) %]
             [% BLOCK params %]
-                [%- FOREACH param IN sql_params %]&amp;sql_params=[% param %][% END %]
+                [%- FOREACH param IN sql_params %]&amp;sql_params=[% param | uri %][% END %]
                     [%- FOREACH param_name IN param_names %]&amp;param_name=[% param_name %][% END %]
             [%- END %]