Bug 25279: (QA follow-up) Use .escapeHtml

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt
index e4c7aa5..618e757 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt
@@ -186,7 +186,7 @@
                     "targets": [0,1,2,3,4],
                     "render": function (data, type, row, meta) {
                         if ( type == 'display' ) {
-                            return $('<div />').text(data).html();
+                            return data.escapeHtml();
                         }
                         return data;
                     }

diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
index 4c6f96c..fad4d61 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
@@ -26,6 +26,13 @@ String.prototype.escapeHtml = function() {
     });
 };
 
+/*
+ * Void method for numbers, for consistency
+ */
+Number.prototype.escapeHtml = function() {
+    return this;
+};
+
 // http://stackoverflow.com/questions/14859281/select-tab-by-name-in-jquery-ui-1-10-0/16550804#16550804
 $.fn.tabIndex = function () {
     return $(this).parent().children('div').index(this);