Bug 23655: Restore debian Jessie support
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Sat, 26 Oct 2019 10:58:18 +0000 (11:58 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Sat, 26 Oct 2019 11:07:49 +0000 (12:07 +0100)
Bug 14570 inadveratntly introduced the use of selectall_array; A feature
that was introduced to DBI version 1.635 which is not available in
debian jessie at the time of writing.

This patch replaces the call with selectall_arrayref which is supported
and works with the rest of the existing code.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

about.pl

index 31b30db..14be586 100755 (executable)
--- a/about.pl
+++ b/about.pl
@@ -474,12 +474,12 @@ $template->param( 'bad_yaml_prefs' => \@bad_yaml_prefs ) if @bad_yaml_prefs;
 
     $bad_relationships_count = $bad_relationships_count->[0]->[0];
 
-    my @existing_relationships = $dbh->selectall_array(q{
-        SELECT DISTINCT(relationship)
-        FROM (
-            SELECT relationship FROM borrower_relationships WHERE relationship IS NOT NULL
-            UNION ALL
-            SELECT relationship FROM borrowers WHERE relationship IS NOT NULL) a
+    my @existing_relationships = $dbh->selectall_arrayref(q{
+          SELECT DISTINCT(relationship)
+          FROM (
+              SELECT relationship FROM borrower_relationships WHERE relationship IS NOT NULL
+              UNION ALL
+              SELECT relationship FROM borrowers WHERE relationship IS NOT NULL) a
     });
 
     my %valid_relationships = map { $_ => 1 } split( /,|\|/, C4::Context->preference('borrowerRelationship') );