Bug 25482: Wrong permissions specification for adv editor macros

The current permissions are defined as a hash, with a duplicate key.
This is generally invalid, but Debian 9's Mojolicious::Plugin::OpenAPI
lets it go through, even though the results are, random?

This patch sets the required permissions right, and following the
haspermissions() syntax correctly.

Tests for searching macros are not passing. Still trying to figure.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/api/v1/swagger/paths/advancededitormacros.json b/api/v1/swagger/paths/advancededitormacros.json
index 120d14d..2fa8f20 100644 (file)
--- a/api/v1/swagger/paths/advancededitormacros.json
+++ b/api/v1/swagger/paths/advancededitormacros.json
@@ -178,8 +178,10 @@
       },
       "x-koha-authorization": {
         "permissions": {
-          "editcatalogue": "advanced_editor",
-          "editcatalogue": "create_shared_macros"
+          "editcatalogue": {
+            "advanced_editor": 1,
+            "create_shared_macros": 1
+          }
         }
       }
     }
@@ -457,8 +459,10 @@
       },
       "x-koha-authorization": {
         "permissions": {
-          "editcatalogue": "advanced_editor",
-          "editcatalogue": "create_shared_macros"
+          "editcatalogue": {
+            "advanced_editor": 1,
+            "create_shared_macros": 1
+          }
         }
       }
     },
@@ -512,8 +516,10 @@
       },
       "x-koha-authorization": {
         "permissions": {
-          "editcatalogue": "advanced_editor",
-          "editcatalogue": "delete_shared_macros"
+          "editcatalogue": {
+            "advanced_editor": 1,
+            "delete_shared_macros": 1
+          }
         }
       }
     }