Bug 24185: Make holds page faster - Improved "if"
authorAndrew Nugged <nugged@gmail.com>
Thu, 19 Dec 2019 16:16:33 +0000 (18:16 +0200)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 25 Mar 2020 09:39:59 +0000 (09:39 +0000)
`$can_item_be_reserved eq 'OK'` moved in `&&` before `IsAvailableForItemLevelRequest`
to cut away with static known values before calling to more resource consuming subroutine.

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

reserve/request.pl

index 5864b3d..f69f706 100755 (executable)
@@ -557,8 +557,8 @@ foreach my $biblionumber (@biblionumbers) {
                 if (
                        !$item->{cantreserve}
                     && !$exceeded_maxreserves
-                    && IsAvailableForItemLevelRequest($item_object, $patron)
                     && $can_item_be_reserved eq 'OK'
+                    && IsAvailableForItemLevelRequest($item_object, $patron)
                   )
                 {
                     $item->{available} = 1;