Bug 23051: (follow-up) Remove call to GetFines

As mentioned by Nick in comment #69 and subsequently discussed on Slack,
the call to GetFines in renew_item was unnececcesary. It has now been
removed.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm
index 8a6f030..8f10ac3 100644 (file)
--- a/Koha/Account/Line.pm
+++ b/Koha/Account/Line.pm
@@ -827,15 +827,6 @@ sub renew_item {
 
     my $itemnumber = $self->item->itemnumber;
     my $borrowernumber = $self->patron->borrowernumber;
-    # Only do something if this item has no fines left on it
-    my $fine = C4::Overdues::GetFine($itemnumber, $borrowernumber);
-    if ($fine && $fine > 0) {
-        return {
-            itemnumber => $itemnumber,
-            error      => 'has_fine',
-            success    => 0
-        };
-    }
     my ( $can_renew, $error ) = C4::Circulation::CanBookBeRenewed(
         $borrowernumber,
         $itemnumber