Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch should...

C4::ImportBatch::GetBestRecordMatch uses SQL to sort by score descending
then candidate_match_id descending. With C4::Matcher::get_matches, I
implement the same sort but use Perl code to do it, since we're sorting
search results.

It's a simple change, but it's in a big block of code, so I don't have
unit tests.

Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/C4/Matcher.pm b/C4/Matcher.pm
index 670b2ef..aaead2f 100644 (file)
--- a/C4/Matcher.pm
+++ b/C4/Matcher.pm
@@ -724,7 +724,10 @@ sub get_matches {
             push @results, { 'record_id' => $authid, 'score' => $matches{$authid} };
         }
     }
-    @results = sort { $b->{'score'} cmp $a->{'score'} } @results;
+    @results = sort {
+        $b->{'score'} cmp $a->{'score'} or
+        $b->{'record_id'} cmp $a->{'record_id'}
+    } @results;
     if (scalar(@results) > $max_matches) {
         @results = @results[0..$max_matches-1];
     }