Bug 19533: Hold pulldown for itemtype is empty if hold placement needs override
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 26 Oct 2017 11:35:53 +0000 (07:35 -0400)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 7 Dec 2017 12:37:10 +0000 (09:37 -0300)
Test Plan:
1) Enable AllowHoldPolicyOverride
2) Enable AllowHoldItemTypeSelection
3) Create a situation where adding a hold for a patron would trigger a tooManyReserves
   warning.
4) Note the itemtype pulldown is empty
5) Apply this patch
6) Reload the page
7) Itemtype pulldown should have values

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

reserve/request.pl

index f4cdc16..919de1f 100755 (executable)
@@ -485,6 +485,8 @@ foreach my $biblionumber (@biblionumbers) {
                     # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
                     $item->{override} = 1;
                     $num_override++;
+
+                    push( @available_itemtypes, $item->{itype} );
                 }
 
                 # If none of the conditions hold true, then neither override nor available is set and the item cannot be checked