Bug 18403: REST API - patrons endpoint

There is something wrond here, the userenv is no set and so we cannot
user search_limited.
Should we set the userenv or filter on the libraries using
libraries_where_can_see_patrons?
WAITING FOR FEEDBACK HERE.

Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/Koha/REST/V1/Patron.pm b/Koha/REST/V1/Patron.pm
index 7cc7bed..8fbe458 100644 (file)
--- a/Koha/REST/V1/Patron.pm
+++ b/Koha/REST/V1/Patron.pm
@@ -24,7 +24,8 @@ use Koha::Patrons;
 sub list {
     my $c = shift->openapi->valid_input or return;
 
-    my $patrons = Koha::Patrons->search;
+    # FIXME The limited does not work here, the userenv is not set
+    my $patrons = Koha::Patrons->search_limited;
 
     return $c->render(status => 200, openapi => $patrons);
 }

diff --git a/api/v1/swagger/paths/holds.json b/api/v1/swagger/paths/holds.json
index adf1178..6bbcd40 100644 (file)
--- a/api/v1/swagger/paths/holds.json
+++ b/api/v1/swagger/paths/holds.json
@@ -154,7 +154,7 @@
         "allow-owner": true,
         "allow-guarantor": true,
         "permissions": {
-          "borrowers": "1"
+          "borrowers": "edit_borrowers"
         }
       }
     },

diff --git a/api/v1/swagger/paths/patrons.json b/api/v1/swagger/paths/patrons.json
index 204ccdf..565d20c 100644 (file)
--- a/api/v1/swagger/paths/patrons.json
+++ b/api/v1/swagger/paths/patrons.json
@@ -44,7 +44,7 @@
       },
       "x-koha-authorization": {
         "permissions": {
-          "borrowers": "1"
+          "borrowers": "edit_borrowers"
         }
       }
     }
@@ -103,7 +103,7 @@
         "allow-owner": true,
         "allow-guarantor": true,
         "permissions": {
-          "borrowers": "1"
+          "borrowers": "edit_borrowers"
         }
       }
     }