Bug 15120: runreport.pl cronjob doesn't allow custom subjects anymore

To test, well do something like

misc/cronjobs/runreport.pl --subject="My fancy subject!" --to=you@youraddress.com 1
where 1 is the number of your favourite saved report.

Success is your email arrives with the subject "My fancy subject!" Failure is
(with --subject defined) you get either the description of the report, or "Koha
saved report" as the subject. This is success without --subject defined.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Bug repeatable and fixed by this patch.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

diff --git a/misc/cronjobs/runreport.pl b/misc/cronjobs/runreport.pl
index 5cc000d..6b25908 100755 (executable)
--- a/misc/cronjobs/runreport.pl
+++ b/misc/cronjobs/runreport.pl
@@ -164,7 +164,7 @@ my $email   = 0;
 my $format  = "text";
 my $to      = "";
 my $from    = "";
-my $subject = 'Koha Saved Report';
+my $subject = "";
 my $separator = ',';
 my $quote = '"';
 
@@ -226,13 +226,16 @@ foreach my $report_id (@ARGV) {
     my $type        = $report->{type};
 
     $verbose and print "SQL: $sql\n\n";
-    if (defined($report_name) and $report_name ne "")
+    if ( $subject eq "" )
     {
-        $subject = $report_name ;
-    }
-    else
-    {
-        $subject = 'Koha Saved Report';
+        if ( defined($report_name) and $report_name ne "")
+        {
+            $subject = $report_name ;
+        }
+        else
+        {
+            $subject = 'Koha Saved Report';
+        }
     }
     # my $results = execute_query($sql, undef, 0, 99999, $format, $report_id);
     my ($sth) = execute_query($sql);