Bug 18936: (follow-up) Add missing circulation rule to fix tests
authorJoonas Kylmälä <joonas.kylmala@helsinki.fi>
Wed, 22 Jan 2020 17:03:03 +0000 (19:03 +0200)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 4 Feb 2020 09:56:28 +0000 (09:56 +0000)
The tests passed before by a chance because the default kohadevbox
installation script added a issuing rule that had lengthunit =
days. If you use a Koha version before the commits introduced by Bug
18936 you can reproduce the Fees.t tests failing by deleting all the
issuing rules from database with

> delete issuingrules;

and then running

$ prove t/db_dependent/Koha/Charges/Fees.t

Signed-off-by: Minna Kivinen <minna.kivinen@hamk.fi>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

t/db_dependent/Koha/Charges/Fees.t

index 431e292..e015927 100644 (file)
@@ -320,6 +320,16 @@ subtest 'accumulate_rentalcharge tests' => sub {
     );
 
     # Daily tests
+    Koha::CirculationRules->set_rules({
+            categorycode => $patron->categorycode,
+            itemtype     => $itemtype->id,
+            branchcode   => $library->id,
+            rules => {
+                lengthunit => 'days',
+            }
+        }
+    );
+
     $itemtype->rentalcharge_daily(1.00);
     $itemtype->store();
     is( $itemtype->rentalcharge_daily,