Bug 25677: Checkbox options for EDI accounts cannot be enabled
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 4 Jun 2020 18:43:58 +0000 (14:43 -0400)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 12 Jun 2020 07:57:47 +0000 (09:57 +0200)
Checking any of the checkboxes in the EDI Account editor does nothing.
They always remain set to "off".

Test Plan:
1) Browse to edi_accounts.pl
2) Create a new EDI account, check all the checkboxes
3) Edit the account, note none of the checkboxes are checked
4) Apply this patch
5) Repeat steps 1-2
6) Note the checkboxes remain checked

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt

index ec5b27b..79388b8 100644 (file)
   <li>
      <label for="quotes_enabled">Quotes enabled: </label>
       [% IF account.quotes_enabled %]
-     <input type="checkbox" name="quotes_enabled" id="quotes_enabled" value="[% account.quotes_enabled | html %]" checked="checked" />
+     <input type="checkbox" name="quotes_enabled" id="quotes_enabled" value="1" checked="checked" />
       [% ELSE %]
-     <input type="checkbox" name="quotes_enabled" id="quotes_enabled" value="[% account.quotes_enabled | html %]" />
+     <input type="checkbox" name="quotes_enabled" id="quotes_enabled" value="1" />
       [% END %]
   </li>
   <li>
      <label for="orders_enabled">Orders enabled: </label>
 [% IF account.orders_enabled %]
-     <input type="checkbox" name="orders_enabled" id="orders_enabled" value="[% account.orders_enabled | html %]" checked="checked" />
+     <input type="checkbox" name="orders_enabled" id="orders_enabled" value="1" checked="checked" />
 [% ELSE %]
-     <input type="checkbox" name="orders_enabled" id="orders_enabled" value="[% account.orders_enabled | html %]" />
+     <input type="checkbox" name="orders_enabled" id="orders_enabled" value="1" />
 [% END %]
   </li>
   <li>
      <label for="invoices_enabled">Invoices enabled: </label>
 [% IF account.invoices_enabled %]
-     <input type="checkbox" name="invoices_enabled" id="invoices_enabled" value="[% account.invoices_enabled | html %]" checked="checked" />
+     <input type="checkbox" name="invoices_enabled" id="invoices_enabled" value="1" checked="checked" />
 [% ELSE %]
-     <input type="checkbox" name="invoices_enabled" id="invoices_enabled" value="[% account.invoices_enabled | html %]" />
+     <input type="checkbox" name="invoices_enabled" id="invoices_enabled" value="1" />
 [% END %]
   </li>
   <li>
      <label for="responses_enabled">Responses enabled: </label>
 [% IF account.responses_enabled %]
-     <input type="checkbox" name="responses_enabled" id="responses_enabled" value="[% account.responses_enabled | html %]" checked="checked" />
+     <input type="checkbox" name="responses_enabled" id="responses_enabled" value="1" checked="checked" />
 [% ELSE %]
-     <input type="checkbox" name="responses_enabled" id="responses_enabled" value="[% account.responses_enabled | html %]" />
+     <input type="checkbox" name="responses_enabled" id="responses_enabled" value="1" />
 [% END %]
   </li>
   <li>
      <label for="auto_orders">Automatic ordering: </label>
 [% IF account.auto_orders %]
-     <input type="checkbox" name="auto_orders" id="auto_orders" value="[% account.auto_orders | html %]" checked="checked" />
+     <input type="checkbox" name="auto_orders" id="auto_orders" value="1" checked="checked" />
 [% ELSE %]
-     <input type="checkbox" name="auto_orders" id="auto_orders" value="[% account.auto_orders | html %]" />
+     <input type="checkbox" name="auto_orders" id="auto_orders" value="1" />
 [% END %]
     <div class="hint">
         With automatic ordering quotes generate orders without staff intervention.