no need to define a const var just to pass it to a sub
authorPaul POULAIN <paul@koha-fr.org>
Thu, 20 Sep 2007 08:31:16 +0000 (10:31 +0200)
committerChris Cormack <crc@liblime.com>
Thu, 20 Sep 2007 20:31:23 +0000 (15:31 -0500)
Signed-off-by: Chris Cormack <crc@liblime.com>

reserve/placerequest.pl

index cb1c5aa..2a5fc05 100755 (executable)
@@ -51,7 +51,7 @@ if ($checkitem ne ''){
                my $item = $checkitem;
                $item = GetItem($item);
                if ( $item->{'holdingbranch'} eq $branch ){
-               $found = 'W';   
+               $found = 'W';
                }
 
 
@@ -74,13 +74,13 @@ if ($type eq 'str8' && $borrowernumber ne ''){
        }
        my $const;
        if ($input->param('request') eq 'any'){
-       $const='a';
-  AddReserve($branch,$borrowernumber->{'borrowernumber'},$biblionumber,$const,\@realbi,$rank[0],$notes,$title,$checkitem,$found);
+            # place a request on 1st available
+            AddReserve($branch,$borrowernumber->{'borrowernumber'},$biblionumber,'a',\@realbi,$rank[0],$notes,$title,$checkitem,$found);
        } elsif ($reqbib[0] ne ''){
-       $const='o';
-  AddReserve($branch,$borrowernumber->{'borrowernumber'},$biblionumber,$const,\@reqbib,$rank[0],$notes,$title,$checkitem, $found);
+            # place a request on a given item
+            AddReserve($branch,$borrowernumber->{'borrowernumber'},$biblionumber,'o',\@reqbib,$rank[0],$notes,$title,$checkitem, $found);
        } else {
-  AddReserve($branch,$borrowernumber->{'borrowernumber'},$biblionumber,'a',\@realbi,$rank[0],$notes,$title,$checkitem, $found);
+            AddReserve($branch,$borrowernumber->{'borrowernumber'},$biblionumber,'a',\@realbi,$rank[0],$notes,$title,$checkitem, $found);
        }
        
 print $input->redirect("request.pl?biblionumber=$biblionumber");