Bug 21267: Set X-FORWARDED-PROTO https if required
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 24 Aug 2018 13:45:52 +0000 (10:45 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 31 Aug 2018 12:46:58 +0000 (12:46 +0000)
This patch makes the apache configuration for the reverse proxy
(required for Plack) so it sets the X-FORWARDED-PROTO header correctly
for Plack::Middleware::ReverseProxy to use it.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Ulrich Kleiber <ulrich.kleiber@bsz-bw.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Since we actually resolve 19799 now (Changing language on OPAC redirects
back to homepage), I will move that code to a new enh report.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

debian/templates/apache-shared-intranet-plack.conf
debian/templates/apache-shared-opac-plack.conf

index 5ae8e07..ff8cd9c 100644 (file)
@@ -22,7 +22,7 @@
 
         ProxyPreserveHost On
 
-       # RequestHeader set X-FORWARDED-PROTO "https"
+        RequestHeader set X-FORWARDED-PROTO "https" env=HTTPS
 
         # Point the intranet site to Plack
         ProxyPass /index.html "unix:/var/run/koha/${instance}/plack.sock|http://localhost/intranet/mainpage.pl"
index 3ea6acd..bee75e9 100644 (file)
@@ -11,7 +11,7 @@
 
         ProxyPreserveHost On
 
-       # RequestHeader set X-FORWARDED-PROTO "https"
+        RequestHeader set X-FORWARDED-PROTO "https" env=HTTPS
 
         # Point the OPAC site to Plack
         ProxyPass /index.html "unix:/var/run/koha/${instance}/plack.sock|http://localhost/opac/opac-main.pl"