Bug 14167: (QA followup) new entries in koha-conf.xml should be tested in about.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>

diff --git a/about.pl b/about.pl
index 4e06ae5..847dc2b 100755 (executable)
--- a/about.pl
+++ b/about.pl
@@ -151,6 +151,12 @@ if ( (C4::Context->config('zebra_auth_index_mode') eq 'grs1') && ($context->{'se
     };
 }
 
+if ( ! defined C4::Context->config('log4perl_conf') ) {
+    push @xml_config_warnings, {
+        error => 'log4perl_entry_missing'
+    }
+}
+
 # Test QueryParser configuration sanity
 if ( C4::Context->preference( 'UseQueryParser' ) ) {
     # Get the QueryParser configuration file name

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
index 782e61d..dd2bf4c 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
@@ -229,6 +229,13 @@
                         to legacy facet calculation.
                     </td>
                 </tr>
+                [% ELSIF config_entry.error == 'log4perl_entry_missing' %]
+                <tr>
+                    <th scope="row"><b>Warning</b></th>
+                    <td>You are missing the &lt;log4perl_conf&gt; entry in your koha-conf.xml file. Please
+                        add it, pointing to the log4perl.conf file for your Koha instance.
+                    </td>
+                </tr>
                 [% END %]
             [% END %]
             </table>