Bug 16951: Fix Item search sorting
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 15 Dec 2016 12:45:22 +0000 (13:45 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Thu, 22 Dec 2016 13:40:05 +0000 (13:40 +0000)
Caused by
  commit ac5a1bfececb5400a77f0ebad90181f5215d5a85
    Bug 16154: CGI->multi_param - Manual changes

The change was wrong, we wanted to retrieve a scalar (the string), not
an array.
We want to retrieve a string with the different column' names, not an
array of 1 element.

Test plan:
Launch an item search and play with column sort

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

catalogue/itemsearch.pl

index a2f0e41..49e56ee 100755 (executable)
@@ -44,7 +44,7 @@ if (defined $format and $format eq 'json') {
     # Map DataTables parameters with 'regular' parameters
     $cgi->param('rows', $cgi->param('iDisplayLength'));
     $cgi->param('page', ($cgi->param('iDisplayStart') / $cgi->param('iDisplayLength')) + 1);
-    my @columns = split /,/, $cgi->multi_param('sColumns');
+    my @columns = split /,/, scalar $cgi->param('sColumns');
     $cgi->param('sortby', $columns[ $cgi->param('iSortCol_0') ]);
     $cgi->param('sortorder', $cgi->param('sSortDir_0'));