Bug 25239: Fix semantic heading for opac-reserve.tt
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 11 Jun 2020 12:05:31 +0000 (13:05 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 24 Jun 2020 13:05:02 +0000 (15:05 +0200)
Prior to this patch, the opac-reserve contained semantically incorrect headings.

Test plan
1/ Perform a search which yields some results in the OPAC
2/ Attempt to place a hold on an item.
3/ On the resulting screen, note that the headings are:
   H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels)
4/ Apply this patch and reload the page
5/ Re-inspect the elements in question note the heading semantics are now:
   H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels)
6/ Note the appearance of the box is still reasonable
7/ Signoff

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt

index 9e73090..bafd73c 100644 (file)
 
             [% UNLESS ( message ) %]
                 [% UNLESS ( none_available ) %]
-                    <h3>Confirm holds for:[% INCLUDE 'patron-title.inc' patron = logged_in_user %] ([% logged_in_user.cardnumber | html %])</h3>
+                    <h2>Confirm holds for:[% INCLUDE 'patron-title.inc' patron = logged_in_user %] ([% logged_in_user.cardnumber | html %])</h2>
                 [% END # / UNLESS none_available %]
 
                 [% IF (RESERVE_CHARGE) %]
                                     [% IF ( bibitemloo.holdable ) %]
                             <div class="holdrow">
                                 [% IF bibitemloo.forced_hold_level %]
-                                    <span class="forced_hold_level"><h5>
+                                    <span class="forced_hold_level"><h3>
                                         [% IF bibitemloo.forced_hold_level == 'item' %]
                                             You already have at least one item level hold on this title.
                                             All further holds must be item level.
                                             You already have at least one record level hold on this title.
                                             All further holds must be record level.
                                         [% END %]
-                                    </h5></span>
+                                    </h3></span>
                                 [% END %]
                                 <p>
                                         <input class="reserve_mode" name="reserve_mode" type="hidden" value="single"/>