Bug 21846: Simplify ugly double for loops

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/t/db_dependent/Tags.t b/t/db_dependent/Tags.t
index 0952e9a..93014bb 100755 (executable)
--- a/t/db_dependent/Tags.t
+++ b/t/db_dependent/Tags.t
@@ -89,8 +89,8 @@ subtest 'add_tag_index() tests' => sub {
         '👍'  => 1,
     };
 
-    for my $term ( keys %{ $terms } ) {
-        for (my $i=1; $i <= $terms->{$term}; $i++) {
+    while ( my ( $term, $count ) = each %$terms ) {
+        for  ( 1 .. $count ) {
             C4::Tags::add_tag_approval( $term );
             C4::Tags::add_tag_index( $term, $biblio->biblionumber );
         }