Bug 13420: Fallback to the previous behavior if published date is not used
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 6 Aug 2019 13:56:44 +0000 (08:56 -0500)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 6 Feb 2020 12:36:12 +0000 (12:36 +0000)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

catalogue/detail.pl
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

index 8e9163a..6f8853f 100755 (executable)
@@ -314,7 +314,7 @@ foreach my $item (@items) {
     $item->{'ccode'} = $collections->{$ccode} if ( defined( $ccode ) && defined($collections) && exists( $collections->{$ccode} ) );
     my $copynumber = $item->{'copynumber'};
     $item->{'copynumber'} = $copynumbers->{$copynumber} if ( defined($copynumber) && defined($copynumbers) && exists( $copynumbers->{$copynumber} ) );
-    foreach (qw(ccode enumchron copynumber stocknumber itemnotes itemnotes_nonpublic uri)) {
+    foreach (qw(ccode enumchron copynumber stocknumber itemnotes itemnotes_nonpublic uri publisheddate)) { # Warning when removing GetItemsInfo - publisheddate (at least) is not part of the items table
         $itemfields{$_} = 1 if ( $item->{$_} );
     }
 
@@ -416,6 +416,7 @@ $template->param(
     itemdata_uri        => $itemfields{uri},
     itemdata_copynumber => $itemfields{copynumber},
     itemdata_stocknumber => $itemfields{stocknumber},
+    itemdata_publisheddate => $itemfields{publisheddate},
     volinfo                => $itemfields{enumchron},
         itemdata_itemnotes  => $itemfields{itemnotes},
         itemdata_nonpublicnotes => $itemfields{itemnotes_nonpublic},
index 214d09c..cb6381f 100644 (file)
                 <th>Home library</th>
                 [% IF ( itemdata_ccode ) %]<th>Collection</th>[% END %]
                 <th>Call number</th>
-                [% IF volinfo %]<th class="title-string">Serial enumeration / chronology</th>[% END %]
+                [% IF volinfo %]
+                    [% IF itemdate_publisheddate #If there is at least one published date, use it for sorting%]
+                        <th class="title-string">Serial enumeration / chronology</th>
+                    [% ELSE %]
+                        <th>Serial enumeration / chronology</th>
+                    [% END %]
+                [% END %]
                 <th>Status</th>
                 <th class="title-string">Last seen</th>
                 <th class="title-string">Date accessioned</th>
@@ -286,7 +292,7 @@ Note that permanent location is a code, and location may be an authval.
                     <td class="itemcallnumber">[% IF ( item.itemcallnumber ) %] [% item.itemcallnumber | html %][% END %]</td>
                     [% IF ( volinfo ) %]
                         <td class="enumchron">
-                            <span title="[% item.publisheddate | html %]">
+                            [% IF itemdate_publisheddate %]<span title="[% item.publisheddate | html %]">[% END %]
                             [% IF ( itemdata_enumchron ) %]
                                 [% IF item.enumchron && item.serialseq %]
                                     <span class="enum">[% item.enumchron | html %]</span>