Bug 18277: [QA Follow-up] Additional polishing

Fix POD error in Biblio.pm, as reported by qa tools:
    Apparent command =cut not preceded by blank line

Resolve crash in t/db_dependent/Items/DelItem.t:
  Can't call method "biblio" on an undefined value at C4/Items.pm line 669.

Add find test in tools/batchMod.pl. Increase readability of map statement.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index 284b4a2..953964c 100644 (file)
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -1442,6 +1442,7 @@ sub GetMarcPrice {
 =head2 MungeMarcPrice
 
 Return the best guess at what the actual price is from a price field.
+
 =cut
 
 sub MungeMarcPrice {

diff --git a/C4/Items.pm b/C4/Items.pm
index 2e5fbc7..036b4f7 100644 (file)
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -666,7 +666,7 @@ sub DelItem {
 
     unless ($biblionumber) {
         my $item = Koha::Items->find( $itemnumber );
-        $biblionumber = $item->biblio->biblionumber;
+        $biblionumber = $item ? $item->biblio->biblionumber : undef;
     }
 
     # If there is no biblionumber for the given itemnumber, there is nothing to delete

diff --git a/tools/batchMod.pl b/tools/batchMod.pl
index 7c87c7f..a1407eb 100755 (executable)
--- a/tools/batchMod.pl
+++ b/tools/batchMod.pl
@@ -125,7 +125,12 @@ if ($op eq "action") {
         my @simple_items_display = map {
             my $itemnumber = $_;
             my $item = Koha::Items->find($itemnumber);
-            { itemnumber => $itemnumber, barcode => ($item->barcode || q||), biblionumber => $item->biblio->biblionumber }} @itemnumbers;
+            {
+                itemnumber   => $itemnumber,
+                barcode      => $item ? ( $item->barcode // q{} ) : q{},
+                biblionumber => $item ? $item->biblio->biblionumber : q{},
+            };
+        } @itemnumbers;
            $template->param("simple_items_display" => \@simple_items_display);
        }