Bug 21239: CSS regressions caused by SCSS move
authorOwen Leonard <oleonard@myacpl.org>
Fri, 17 Aug 2018 12:47:52 +0000 (12:47 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 24 Aug 2018 16:23:25 +0000 (16:23 +0000)
This patch corrects some mistakes in staff-global.scss made during the
conversion from CSS.

To test, apply the patch and regenerate your CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear your browser cache if necessary.

View various forms in the staff client which have hints and required
fields, including:

- Notices & slips -> Modify notice
- Administration -> Budgets -> Modify budget

Verify that date format hints are positioned correctly. Try to submit
the form with empty required fields and verify that the "This field is
required" message is positioned correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss

index 5e3d289..2fc5b84 100644 (file)
@@ -895,7 +895,7 @@ fieldset {
         border: 2px solid #B9D8D9;
 
         div {
-            .hint {
+            &.hint {
                 margin-bottom: .4em;
             }
         }
@@ -1010,9 +1010,9 @@ fieldset {
         }
 
         div {
-            .hint {
+            &.hint {
                 margin-bottom: .4em;
-                margin-left: 7.5em;
+                margin-left: 10.5em;
             }
         }
 
@@ -1120,7 +1120,7 @@ fieldset {
                 font-weight: bold;
                 margin-right: 1em;
                 text-align: right;
-                width: 6em;
+                width: 9em;
             }
         }
 
@@ -1167,7 +1167,7 @@ fieldset {
 
 .yui-u {
     div {
-        .hint {
+        &.hint {
             margin-bottom: .4em;
         }
     }