Bug 26114: ILL should mark status=RET only if a return happened
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 31 Jul 2020 14:14:20 +0000 (11:14 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 13 Aug 2020 08:15:33 +0000 (10:15 +0200)
commitf916269465df99818fb15c108820d3b666968d39
treec7db92e6488ef00e9bd15a2c8a6d80f24bcdbc50
parent8b106ed9c4b0588502c6dd485de2aec6a80b32c6
Bug 26114: ILL should mark status=RET only if a return happened

The original code assumed every codepath should be trated as a
successful check-in. Such is not the case and the regression tests
verify that the code acknowledges this.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Illrequests.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Circulation.pm