Bug 8995: (follow-up) Add tests, move open_url/coins routines to Koha namespace
authorJosef Moravec <josef.moravec@gmail.com>
Mon, 11 Mar 2019 21:27:52 +0000 (21:27 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 29 Apr 2019 15:34:10 +0000 (15:34 +0000)
commitd99d32d033935f09b7c361177ac4b43f08b8c14a
tree29acb394008cfb595f6b2541338314f9c1e8a859
parent29c687bff71c2530adeaaf2bdfbfa1ea565ba5e5
Bug 8995: (follow-up) Add tests, move open_url/coins routines to Koha namespace

Test plan:
1) Ensure the COinS span tag is still included on this pages. You need
to look into html source and search for span tag with class 'Z3988',
   which has COinS string in title.
   Staff client:
       catalogue -> ISBDdetail
       catalogue -> MARCdetail
       catalogue -> detail
       virtualshelves -> shelves
    OPAC (you should have COinSinOPACResults system preference enabled):
        opac detail
        opac search
        opac shelves
2) Run tests:
prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Tested with all 9 current patches. Works as advertised, including
OPACURLOpenInNewWindow. If a record has no items, no OpenURL link
is displayed. All the suggested tests pass. I did not test with
XSLT turned off.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
13 files changed:
C4/Biblio.pm
C4/XSLT.pm
Koha/Biblio.pm
catalogue/ISBDdetail.pl
catalogue/MARCdetail.pl
catalogue/detail.pl
opac/opac-detail.pl
opac/opac-search.pl
opac/opac-shelves.pl
t/Biblio.t
t/db_dependent/Biblio.t
t/db_dependent/Koha/Biblio.t
virtualshelves/shelves.pl