Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 30 Aug 2016 16:04:28 +0000 (17:04 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 21 Oct 2016 15:35:21 +0000 (15:35 +0000)
commitcd7b84f6754ca264070afcac6fc8cb65ea0f930e
tree3fd61fdec756af233e8bea53a69885fa90996f40
parent8323db303dd6d1c486574e7750ad58df2c25c744
Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode

The subroutine C4::Koha::GetAuthorisedValueByCode returned the
description (staff or opac) for a given authorised value.

Note that we may need a unique key to ->find instead of ->search.

Test plan:
- Checkin an item that cannot be checked in because it's lost, the
  message should display the AV description
- Generate a letter with borrowers.streettype equals an ROADTYPE AV, the
  description should be displayed.
- Edit a patron attribute type, the AV dropdown list should be
  displayed
- Create the PA_CLASS AV category (see bug 7154) and make sure it
  behaves as before when editing a patron
- The checkout list should display descriptions for LOC, LOST and
  DAMAGED

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 files changed:
C4/Circulation.pm
C4/Koha.pm
C4/Letters.pm
Koha/Template/Plugin/AuthorisedValues.pm
admin/patron-attr-types.pl
circ/circulation.pl
members/memberentry.pl
members/moremember.pl
reports/borrowers_stats.pl
suggestion/suggestion.pl
svc/checkouts
t/db_dependent/Koha.t