Bug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 1 Mar 2018 13:29:01 +0000 (14:29 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 7 Sep 2018 13:16:06 +0000 (13:16 +0000)
commitc1d2363063d1c3eb2d37e45c9a3074cea9c783b4
tree893b5a7d2caffdfe30ab249c27c32cbf94d12702
parent86bcc81122f20a096f46ac66de3d95ec21dcbd96
Bug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes

This routine looks at the issuingrules and makes a fast 'intelligent
guess' if article requests may be allowed for item types while
branch code and patron category may not be available.

We also add Koha::Biblio->may_article_request using the routine based
on default item type or parameter. Implemented as both class and instance
method. Added a few tests.

Test plan:
[1] Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t
[2] Run t/db_dependent/ArticleRequests.t to test Koha::Biblio changes.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Biblio.pm
Koha/IssuingRules.pm
t/db_dependent/ArticleRequests.t
t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t [new file with mode: 0644]