Bug 7976: Remove the borrow permission
authorJonathan Druart <jonathan.druart@biblibre.com>
Mon, 30 Mar 2015 16:18:16 +0000 (18:18 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Fri, 5 Jun 2015 16:43:34 +0000 (13:43 -0300)
commitbaea0a79d5d4dbe46eb052d7e52f5dcf7b5242bc
treecc8707a17d427abbbd50dc0b302d22cd19930c17
parent83c6817a86de68fb08cb73aef3b8b46d12587116
Bug 7976: Remove the borrow permission

The borrow permission was used but uselessly.
For instance, at the opac, the flagsrequired parameter was set to
'borrow' but the 'authnotrequired' was set also (which means no auth
required).
At the end, this permission was used at only 1 place: for the basket,
intranet side.
This can be replaced with the catalogue permission (which is used to
search).

Test plan:
1/ Confirm that you are able to show/download/sent the cart (intranet side)
with the catalogue permission.
2/ At the OPAC, you should be able to access the same pages as before
with any other permissions.

Concretely it is quite difficult to test this patch, you should have a
look at the code.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
36 files changed:
C4/Auth.pm
C4/InstallAuth.pm
basket/basket.pl
basket/downloadcart.pl
basket/sendbasket.pl
installer/data/mysql/de-DE/mandatory/userflags.sql
installer/data/mysql/en/mandatory/userflags.sql
installer/data/mysql/es-ES/mandatory/userflags.sql
installer/data/mysql/fr-FR/1-Obligatoire/userflags.sql
installer/data/mysql/it-IT/necessari/userflags.sql
installer/data/mysql/nb-NO/1-Obligatorisk/userflags.sql
installer/data/mysql/pl-PL/mandatory/userflags.sql
installer/data/mysql/ru-RU/mandatory/permissions_and_user_flags.sql
installer/data/mysql/uk-UA/mandatory/permissions_and_user_flags.sql
installer/data/mysql/updatedatabase.pl
opac/opac-account.pl
opac/opac-basket.pl
opac/opac-detail.pl
opac/opac-downloadcart.pl
opac/opac-downloadshelf.pl
opac/opac-ics.pl
opac/opac-imageviewer.pl
opac/opac-main.pl
opac/opac-messaging.pl
opac/opac-modrequest-suspend.pl
opac/opac-modrequest.pl
opac/opac-mymessages.pl
opac/opac-passwd.pl
opac/opac-privacy.pl
opac/opac-readingrecord.pl
opac/opac-renew.pl
opac/opac-reserve.pl
opac/opac-sendbasket.pl
opac/opac-sendshelf.pl
opac/opac-user.pl
opac/svc/shelfbrowser.pl