Bug 20946: Use K::Account->outstanding_debits in pay.pl and paycollect.pl
authorTomas Cohen Arazi <tomascohen@theke.io>
Sat, 16 Jun 2018 12:44:19 +0000 (09:44 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 6 Jul 2018 10:33:13 +0000 (10:33 +0000)
commitb0cb7f44ef80d5f6a3d45ce87543a27637c68c6f
tree42ae83c5b397dab6ff12e4dfa5777e9f75733970
parent0e45263492dbd8123bf2507aad6dc45d95c4902c
Bug 20946: Use K::Account->outstanding_debits in pay.pl and paycollect.pl

This patch changes the how account lines are fetched (using
Koha::Account->outstanding_debits) so credits are not picked.

To test:
- Add a $5 credit to a patron
- Add a $1 fine
- Go to the 'Pay fines' tab
=> FAIL: Credit is displayed
- Try to pay all fines
=> FAIL: You are told to enter a value less than or equal to -4.00
         (Observe you cannot do that)
- Apply this patch
- Reload
=> SUCCESS: Credit is not displayed
=> SUCCESS: You are able to pay all fines
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
members/pay.pl
members/paycollect.pl