Bug 13098: Make _FixAccountForLostAndReturned refund the right thing
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 18 Oct 2018 16:08:42 +0000 (13:08 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Wed, 31 Oct 2018 13:13:37 +0000 (13:13 +0000)
commit7dd4d60c8a9118e13b02b4dc60612df4cbc95f91
tree4611651317bb3e3207960f83f5a12dcf885295a6
parent0fb422d8f9dba77edde17d18eeac6471c7245730
Bug 13098: Make _FixAccountForLostAndReturned refund the right thing

This patch changes the logic inside the method, to make it match the
behaviour described on the tests.

It uses the existing offsets on the account_offsets table to gather
information about the right things to refund.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation.t
=> FAIL: Tests don't pass!
- Apply this patch
- Run
 k$ prove t/db_dependent/Circulation.t
=> SUCCESS: Tests pass!
- Sign off :-D

Followed test plan, patch works as described. All three patches pass QA
test tool
Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Circulation.pm