Bug 20946: (QA follow-up) make outstanding_debits return the account lines only
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 2 Jul 2018 15:05:55 +0000 (12:05 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 6 Jul 2018 10:33:14 +0000 (10:33 +0000)
commit72058d27415a82799d9f6acac693e94dc7bf9309
tree09d3b0283ca14dedcbf90d7f36d03f0a79ba8d51
parent158e50d0bcf214932fb1ca037049e6515fbbd80c
Bug 20946: (QA follow-up) make outstanding_debits return the account lines only

This patch was discussed with Jonathan on a QA conversation. It is
better to keep this simpler and more reusable. And is the right approach
in this case.

This patch makes Koha::Account::outstanding_debits return the account
lines, and a method is added to Koha::Account::Lines so the outstanding
amount is calculated on the resultset. This is done the dame way it was
done before, and the tests got adjusted.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Account.pm
Koha/Account/Lines.pm
members/pay.pl
members/paycollect.pl
t/db_dependent/Koha/Account.t
t/db_dependent/Koha/Account/Lines.t