Bug 11512: Forced holds that violate issuing rules will never be filled
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 26 Oct 2017 11:40:04 +0000 (07:40 -0400)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 6 Apr 2018 17:51:11 +0000 (14:51 -0300)
commit5d1b491a799f4ca42cbe46809811539897647f8f
tree0d84408265786905845bd33aacd1441750962476
parentf46ead631325dc86e7ff15344095b8b845cff7f3
Bug 11512: Forced holds that violate issuing rules will never be filled

Currently in Koha, if you choose to force a hold from the staff side that would contravened the current issuing rules, that hold will never be filled, as it is always skipped over by CheckReserves.

This patch disallows overrideing except for tooManyReserves which are the only overridden holds that will be trapped.

Test Plan:
1) Apply this patch
2) Attempt to override hold placement, only placements where the patron has too many holds already should be allowed

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
reserve/request.pl