Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 25 Nov 2016 12:02:01 +0000 (12:02 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 10 Jul 2017 15:06:37 +0000 (12:06 -0300)
commit546379cc92b733cb29a0b70247a72c770afdad26
treee923267c79350c9a0fc66ce76f870d52e3abcd32
parentd9c8eea442bbe4e30be172d547e519dcd781341d
Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls

C4::Circulation::GetItemIssue returned all the issue and item
informations for a given issue. Moveover it also did some date
manipulations. Most of the time this subroutine was called, there
additional information were useless as the caller usually just needed
the basic issue's infos 'from the issue table).

This first patch updates the simple calls, ie. the ones that just need
the issue's infomations.

Test plan:
The following operations should success:
- transfer a book
- create a rule for on-site checkouts and confirm that a patron cannot
check more items out that it's defined in the rule.
- Renew an issue using ILSDI
- Using SIP confirm that you are able to see your issues

Followed test plan, works as expected
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Circulation.pm
C4/ILSDI/Services.pm
C4/SIP/ILS/Item.pm
C4/SIP/ILS/Transaction.pm
offline_circ/enqueue_koc.pl
offline_circ/process_koc.pl
opac/opac-reserve.pl
reserve/request.pl
t/db_dependent/Circulation.t
t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
t/db_dependent/Circulation/issue.t