Bug 16155: Adjust a few other tests
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 29 Mar 2016 13:32:24 +0000 (15:32 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 4 May 2016 13:47:58 +0000 (13:47 +0000)
commit2862b19918c722a7a0e5cc8151c4ebdd32f13323
tree14229cbe14976ce359e5f9908e341a4aa70e6df7
parent9de3872b907c6771cf8b70ebc303247d8dddb87c
Bug 16155: Adjust a few other tests

Accounts.t: Only added a line that ensures the MPL branch exists.
AnonymiseIssueHistory.t: Only add a branch to work with.
Barcodes.t: Replaced clear with delete_all.
CalcFine.t: Remove default issuing rule and add one instead of updating.
Holds.t: Add category S in case it would not exist.
Members.t: Replaced clear with delete_all.
MoveItemFromBiblio.t: Replace last _fk construction.

Test plan:
Run these tests. (See note).
Git grep for only_fk, {_fk} and TestBuilder::default_value.

Note: Holds.t does not pass. Tests 9 and 39 fail, but they did already.
not ok 9 - GetReservesFromItemnumber should return a valid borrowernumber
not ok 39 - Test AlterPriority(), move to bottom
So this test needs attention, but on another report please :)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/Accounts.t
t/db_dependent/Barcodes.t
t/db_dependent/Circulation/AnonymiseIssueHistory.t
t/db_dependent/Circulation/CalcFine.t
t/db_dependent/Holds.t
t/db_dependent/Items/MoveItemFromBiblio.t
t/db_dependent/Members.t